I'm new to Terraform but after reviewing this PR I think you may have missed somethings. You should probably add a check for the state of monitoring on the read and add a check for update as well as the update much like how private_networking is done. Well done though otherwise!

I stand corrected. Currently it doesn't look like you can query the droplet to see if monitoring is enabled.

Closes #13376.

Hi @joshpurvis

Thanks so much for the contribution here - in it's current format, I don't think I can merge it. There are a few reasons for this:

1. If we cannot update the value, then we need to set the parameter ForceNew: true on the schema value. If we don't do this, then if a user disables monitoring in their config then they will believe something has changed when it hasn't

2. We are not able to set the value back to state in the Read func as you pointed out. This will break import functionality and when a user sets the value, it will then force a new droplet

You pointed both of these things out of course, but I think we may need DigitalOcean to provide a fix for #2 and we can easily set #1 ourselves :)

What do you think?

Paul

Yep I tend to agree. I've created a support ticket with Digitalocean.

Hi Luke,

Thanks for contacting us today. Sorry for the confusion with all of this. Monitoring management through the API is not fully implemented yet as you have seen. There isn't even a documentation section on it in the API docs at this stage. Our monitoring team is working on getting that fully implemented into the API soon as well as the documentation for it. Currently you are able to implement it but as you have seen this doesn't show up in the features. We do hope to see that available soon.

Let us know if you have any questions.

This is what DO responded with to me after I looked into it.

@joshpurvis It looks like DO has included the required field in the features block

"features": [
    "backups",
    "private_networking",
    "ipv6",
    "monitoring"
],

Might also have to move this PR to the new repository as well

Hello @joshpurvis, and all!

Thank you for the contribution, we would love to be able to support this in the DigitalOcean provider!

However, with the migration of all of our providers to their new GitHub organizations (https://www.hashicorp.com/blog/upcoming-provider-changes-in-terraform-0-10), the DigitalOcean provider is now located at: https://github.com/terraform-providers/terraform-provider-digitalocean.

As such, I'm going to close this PR, as we cannot merge it in it's current state. If you wouldn't mind migrating this PR over to the new repository, I will happily review it for you (Just tag me as a requested reviewer).

Thanks again, and sorry for the inconvenience!

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.